Skip to content

Conversation

@bynect
Copy link
Contributor

@bynect bynect commented Apr 16, 2024

In retrospect this should have been added before the release, but better later than never...

@bynect
Copy link
Contributor Author

bynect commented Apr 16, 2024

Similar to vim features dump, also prints the cflags.

Dunst - A customizable and lightweight notification-daemon v1.10.0-96-g1ceac34
Compiled on Apr 16 2024 with the following options:
X11 support enabled
Wayland support disabled
SYSCONFDIR set to /usr/local/etc/xdg
Compile flags: -g -std=gnu11 -pedantic -Wall -Wno-overlength-strings -Os -pthread -MMD -MP
Linker flags: -lm -lrt -lpangocairo-1.0 -lpango-1.0 -lgobject-2.0 -lharfbuzz -lcairo -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lglib-2.0 -lX11 -lXinerama -lXext -lXrandr -lXss

@codecov
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.88%. Comparing base (4384521) to head (3dc0b63).

Files Patch % Lines
src/dunst.c 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   65.92%   65.88%   -0.05%     
==========================================
  Files          50       50              
  Lines        8070     8075       +5     
  Branches      925      925              
==========================================
  Hits         5320     5320              
- Misses       2750     2755       +5     
Flag Coverage Δ
unittests 65.88% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This also prevents unneeded dynamic linkage
Makefile Outdated
${OBJ} ${TEST_OBJ}: Makefile config.mk

src/dunst.o: src/dunst.c
${CC} -o $@ -c $< ${CPPFLAGS} ${CFLAGS} -D_CFLAGS="$(filter-out $(filter -I%,${INCS}),${CFLAGS})" -D_LDFLAGS="${LDFLAGS}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: filter out includes to declutter output (the user won't probably care either way)

@bynect bynect requested review from fwsmit and zappolowski April 18, 2024 18:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.88%. Comparing base (4384521) to head (ca8caee).

Files Patch % Lines
src/dunst.c 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   65.92%   65.88%   -0.05%     
==========================================
  Files          50       50              
  Lines        8070     8075       +5     
  Branches      925      925              
==========================================
  Hits         5320     5320              
- Misses       2750     2755       +5     
Flag Coverage Δ
unittests 65.88% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit dc5afa3 into dunst-project:master Apr 19, 2024
@bynect bynect deleted the print-comp-info branch April 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants