feature(wireless-discovery): Rewrite Pairing device with pairing code using mDNS like Android Studio#23
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
📝 WalkthroughWalkthroughThis PR refactors Android device wireless pairing from a single-dialog approach (host+code entry) to a multi-phase flow featuring device discovery via mDNS, device selection, and optional manual entry. New UI components ( ChangesWireless Pairing and Device Discovery Flow
Sequence DiagramsequenceDiagram
actor User
participant WCD as WirelessConnectDialog
participant WDS as WifiDiscoveryService
participant ADB as AndroidDeviceService
participant Device as Android Device
User->>WCD: Open pairing dialog
WCD->>WDS: watchPairingDevices()
WDS->>WDS: Scan mDNS for _adb-tls-pairing._tcp
WDS-->>WCD: Stream discovered WifiPairingDevice
User->>WCD: Select device from list
WCD->>WCD: Show enter-code phase
User->>WCD: Enter 6-digit pairing code
User->>WCD: Submit (press Enter)
WCD->>ADB: pairDevice(host, pairingCode)
ADB->>Device: ADB pairing request with code
Device-->>ADB: Pairing success/failure
ADB-->>WCD: AdbConnectResult
alt Pairing Success
WCD->>WCD: Show success dialog
WCD->>WCD: Refresh device list
else Pairing Failed
WCD->>WCD: Show error dialog
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~65 minutes Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
dungngminh
added a commit
that referenced
this pull request
May 2, 2026
… using mDNS like Android Studio (#23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor Wi-Fi wireless pairing flow to match Android Studio behavior:
WifiDiscoveryService(backed bymulticast_dns) continuously scans for_adb-tls-pairing._tcpendpoints and streams discovered devices in real time.wireless_pairing_dialog.dart(205 lines) with newwireless_pairing/wireless_pairing_dialog.dart(716 lines). New flow — discover devices → select → enter 6-digit PIN → resolve connect endpoint → connect. Mirrors Android Studio pairing UX.LoadingState,PinCodeFieldsadded for reuse across dialogs.WifiPairingDevice,WirelessPairingInfo,WirelessConnectRequest,AdbConnectResult.Type of Change
Summary by CodeRabbit
Release Notes – Version 0.5.0
New Features
Bug Fixes