-
-
Notifications
You must be signed in to change notification settings - Fork 832
doc: add information about building production image #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @tcoch! Thank you for adding this information to the manual. This is really important information! It seems to me that it is better not to place the instructions on how the project should be built for deployment in the Deployment section. Perhaps it would be worth adding an additional section like Preparing for deployment? Then, in addition to clarifying the command for building the image, it would be possible to list some nuances when working with images of this template. |
Hi @7-zete-7, |
Sounds very reasonable, @tcoch! You are right, it will be better than my suggestion. And the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, I just have one question
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Co-authored-by: Maxime Helias <maximehelias16@gmail.com>
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Thanks @tcoch ! |
Due to issues #745 (probably) and #751 (and some seens on StackOverflow also), I propose to be a little more precise about the building of production images.