Skip to content

doc: add information about building production image #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 12, 2025

Conversation

tcoch
Copy link
Contributor

@tcoch tcoch commented Mar 7, 2025

Due to issues #745 (probably) and #751 (and some seens on StackOverflow also), I propose to be a little more precise about the building of production images.

@7-zete-7
Copy link
Contributor

7-zete-7 commented Mar 8, 2025

Hi, @tcoch!

Thank you for adding this information to the manual. This is really important information!

It seems to me that it is better not to place the instructions on how the project should be built for deployment in the Deployment section.

Perhaps it would be worth adding an additional section like Preparing for deployment?

Then, in addition to clarifying the command for building the image, it would be possible to list some nuances when working with images of this template.

@tcoch
Copy link
Contributor Author

tcoch commented Mar 8, 2025

Hi @7-zete-7,
I kinda like the production.md file as it is, I don't want it to have too much informations.
I'm thinking maybe I could add these extra informations to the troubleshooting.md file ? WDYT ?

@7-zete-7
Copy link
Contributor

7-zete-7 commented Mar 8, 2025

Sounds very reasonable, @tcoch!

You are right, it will be better than my suggestion. And the production.md file will not be overloaded with information.

Copy link
Collaborator

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, I just have one question

Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
tcoch and others added 2 commits March 10, 2025 10:37
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
Co-authored-by: Maxime Helias <maximehelias16@gmail.com>
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
@maxhelias
Copy link
Collaborator

Thanks @tcoch !

@maxhelias maxhelias merged commit 4b3dd9a into dunglas:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants