Add yarn/npm

[fherbin]

everything is in the title
can you add yarn to the php container?

[dunglas]

It's not a good idea in production. We need to find a way to have them in dev but not in prod.

[BaptisteCrouzet]

It's not a good idea in production. We need to find a way to have them in dev but not in prod.

Why it is not a good idea in production ? Is it for build time reasons ?

[dunglas]

Mostly for security reasons. You don't want something useless in prod in your images.

[fherbin]

maybe a little off topic but, isn't it a good practice that services in containers are not executed as root ?

[Julien-Broyard]

You could create a docker-compose.dev.yml and add the node.js image with yarn there.

Then you could run this command.

docker-compose up -f docker-compose.yml -f docker-compose.dev.yml

How is it ?

[torbenbr]

You can add this in your Dockerfile

before php stage

ARG NODE_VERSION=14

# node "stage"
FROM node:${NODE_VERSION}-alpine AS symfony_assets_builder

WORKDIR /srv/app

RUN mkdir public

COPY package.json yarn.lock ./

RUN yarn install

COPY assets assets/
COPY webpack.config.js ./

RUN yarn build

And this in the php stage

COPY --from=symfony_assets_builder /srv/app/public/build public/build

[abdounikarim]

Hello, can we use something like this in the docker-compose.override.yaml file ?

encore:
        command: ["yarn", "dev-server", "--host=0.0.0.0"]
        container_name: encore
        image: node:10-alpine
        ports:
            - "${DEV_SERVER_PORT:-8080}:8080"
        volumes:
            - .:/srv/app

And use this command to generate assets :

docker-compose run encore yarn --cwd /srv/app watch

With the current configuration, this will be used only in dev right ?

[torbenbr]

With the current configuration, this will be used only in dev right ?

Yes the dev server is only for dev ;) For prod you can use my example.

[HidouriAnis]

@torbenbr does this work for you? i think the order for your steps is not good,
i have this when i apply your changes:

Step 7/42 : COPY package.json yarn.lock ./
ERROR: Service 'php' failed to build: COPY failed: file not found in build context or excluded by .dockerignore: stat package.json: file does not exist

[torbenbr]

@HidouriAnis I think, in your case you don't have a yarn.lock file. Is that right? For ease of use you can change the copy step to copy. .