-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding Pharaoh legacy (uni v2) support for dex.trades on avalanche_c #8535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding support for uni v2 style legacy trades for Pharaoh exchange over on avalanche_c
Workflow run id 16484402366 approved. |
Workflow run id 16484402300 approved. |
Workflow run id 16484402310 approved. |
Workflow run id 16486415700 approved. |
Workflow run id 16497314752 approved. |
Workflow run id 16497314751 approved. |
Workflow run id 16497315302 approved. |
Workflow run id 16497783871 approved. |
Workflow run id 16497783879 approved. |
Workflow run id 16497784143 approved. |
Currently error'n out on:
But I can
I'm guessing I'm not remembering/understanding the source it's referring to? |
Workflow run id 16498497839 approved. |
Workflow run id 16498497849 approved. |
Workflow run id 16498498205 approved. |
fixed seed (i hope)
Workflow run id 16501851744 approved. |
Workflow run id 16501851750 approved. |
Workflow run id 16501851963 approved. |
Workflow run id 16511018088 approved. |
Workflow run id 16511018278 approved. |
Workflow run id 16511038763 approved. |
Workflow run id 16511038766 approved. |
Workflow run id 16511038984 approved. |
Workflow run id 16543207057 approved. |
Workflow run id 16543207063 approved. |
Workflow run id 16543207160 approved. |
Workflow run id 16543384927 approved. |
Workflow run id 16543384941 approved. |
Workflow run id 16543385245 approved. |
Workflow run id 16557350820 approved. |
Workflow run id 16557350769 approved. |
Workflow run id 16557350767 approved. |
Workflow run id 16594338042 approved. |
Workflow run id 16594338043 approved. |
Workflow run id 16594338333 approved. |
marking back as draft until CI is passing. |
![]() so my seed wasn't finding match and it turns out there's a super weird decode (issue?) with duplicate Pair contracts within the pharaoh namespace on avalanche_c ref: https://discord.com/channels/757637422384283659/1397931881701445783 once this is fixed, the PR should go through. I wonder if I might be able to get an extra eyeball or two on this. |
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
It's been a very long time since I've attempted this, so bare with me.
Attempting to add pharaoh legacy swap support to dex.trades.
quick links for more information: