[7.x] Basic tax engine shipping VAT fix #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for calculating the VAT price for shipping. It sets the same behavior as for the line items.
rolinbos
changed the title
rolinbos
changed the title
rolinbos
changed the title
duncanmcclean
requested changes
Oct 7, 2024
| @@ -0,0 +1,3 @@ | |||
| tabs: | |||
There was a problem hiding this comment.
The changes in this file seem unrelated. Can you please revert them?
| @@ -1,372 +1,3 @@ | |||
| title: Order | |||
| tabs: | |||
There was a problem hiding this comment.
The changes in this file seem unrelated. Can you please revert them?
| - | ||
| handle: price | ||
| handle: product_variants |
There was a problem hiding this comment.
We don't need the product_variants field in this blueprint. Are you able to revert this file back to how it was?
|
Hi @duncanmcclean, thanks for your feedback. I've changed the files. |
duncanmcclean
approved these changes
Oct 7, 2024
|
Thanks! |
|
Released as part of v7.5.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this moment when you define that the basic tax engine
included_in_pricesis set to true, it will think that the shipping costs also is included in the price. But the calculation of it isn't correct.With this PR, it will check for the basic tax engine if the
included_in_pricesis true or false.Before it calculates the VAT for shipping with 100 but it needs to be 100 + VAT rate so that you can calculate the price without VAT.
For example the shipping price is 6.50 with VAT. And the VAT is 21%
Before this PR:
650 / 100 * 21 = 136,5 = 137So the price without VAT is:
650 - 137 = 513But this isn't right.
With this PR:
650 / 121 * 21 = 112,80 = 113So the price without VAT is:
650 - 113 = 537