fix: ignore dots inside brackets when extracting basename #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm using .test, .setup, etc. and to ignore it, if I allow ignoreMiddleExtensions, I get an error in the app router's [...auth] etc
This PR fixes the
getBasenamefunction to properly handle dots inside brackets (e.g.,[...]) when extracting the base filename. Previously, dots inside brackets were incorrectly treated as extension separators.Problem
When processing filenames with brackets containing dots (e.g., Next.js dynamic routes like
[[...slug]].tsx), thegetBasenamefunction would incorrectly identify dots inside brackets as extension delimiters.Example:
getBasename('[[...slug]].tsx')would incorrectly split at the first dot inside bracketsgetBasename('[[...slug]].tsx')correctly returns'[[...slug]]'Solution
Modified the
getBasenamefunction to:Changes
Core Changes
lib/utils/filename.js: RefactoredgetBasenameto skip dots inside bracketsfindDotsOutsideBracketshelper function