Sigh. It's 2017 and yet here I am on a rainy Saturday afternoon fixin…

…g LOG_TRACE code because we are not compiling in this mode in our pipeline
dujl · Dec 23, 2017 · 95f58eb · 95f58eb
1 parent 45509c0
commit 95f58eb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/test/function/timestamp_functions_test.cpp b/test/function/timestamp_functions_test.cpp
@@ -64,8 +64,9 @@ void DateTruncTestHelper(DatePartType part, std::string &date,
   // Check that result is *not* null
   EXPECT_NE(result, type::PELOTON_TIMESTAMP_NULL);
   // Then check that it equals our expected value
-  LOG_TRACE("COMPARE: %s = %s\n", expected.ToString().c_str(),
-            result.ToString().c_str());
+  LOG_TRACE("COMPARE: %s = %" PRId64 "\n",
+            expected.c_str(),
+            static_cast<long>(result));
   EXPECT_EQ(result, int_expected);
 }
 

diff --git a/test/type/boolean_value_test.cpp b/test/type/boolean_value_test.cpp
@@ -111,7 +111,9 @@ TEST_F(BooleanValueTests, ComparisonTest) {
         }  // SWITCH
         LOG_TRACE("%s %s %s => %d | %d\n", val0.ToString().c_str(),
                   ExpressionTypeToString(etype).c_str(),
-                  val1.ToString().c_str(), expected, result);
+                  val1.ToString().c_str(),
+                  static_cast<int>(expected),
+                  static_cast<int>(result));
 
         if (expected_null) expected = false;
 

diff --git a/test/type/date_value_test.cpp b/test/type/date_value_test.cpp
@@ -97,7 +97,9 @@ TEST_F(DateValueTests, ComparisonTest) {
         }  // SWITCH
         LOG_TRACE("%s %s %s => %d | %d\n", val0.ToString().c_str(),
                   ExpressionTypeToString(etype).c_str(),
-                  val1.ToString().c_str(), expected, result);
+                  val1.ToString().c_str(),
+                  static_cast<int>(expected),
+                  static_cast<int>(result));
 
         if (expected_null) {
           EXPECT_EQ(expected_null, result == type::CmpBool::NULL_);

diff --git a/test/type/timestamp_value_test.cpp b/test/type/timestamp_value_test.cpp
@@ -97,7 +97,7 @@ TEST_F(TimestampValueTests, ComparisonTest) {
         }  // SWITCH
         LOG_TRACE("%s %s %s => %d | %d\n", val0.ToString().c_str(),
                   ExpressionTypeToString(etype).c_str(),
-                  val1.ToString().c_str(), expected, result);
+                  val1.ToString().c_str(), expected, static_cast<int>(result));
 
         if (expected_null) {
           EXPECT_EQ(expected_null, result == type::CmpBool::NULL_);