Adding sound support via soundcmd in config.h#51
Open
Binkersss wants to merge 2 commits intodudik:masterfrom
Open
Adding sound support via soundcmd in config.h#51Binkersss wants to merge 2 commits intodudik:masterfrom
Binkersss wants to merge 2 commits intodudik:masterfrom
Conversation
Author
|
Sorry, I've just realized you may prefer this to be a patch. Let me know and I can change the formatting of this pr. Honestly I feel like sound is becoming a basic function of a notification, and this addition is only 17 lines so I thought it was acceptable to create a basic PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sound is enabled by switching the populating the soundcmd array.
Example:
Sound support is disabled by support. This is from a personal patch I've been using for a little bit and has saved me from letting my laptop die a ton. Without the sound, I will never notice it.