Set window masks during window creation#29
Open
TAAPArthur wants to merge 1 commit intodudik:masterfrom
Open
Conversation
Instead of making a separate call to set window masks, set them during creation. Also replace the erroneous ButtonPress with ButtonPressMask. The former is meant as a event type while the letter is an event mask. They happen to have the same value, but this is not true for most events
explosion-mental
added a commit
to explosion-mental/herbe
that referenced
this pull request
Feb 10, 2022
Instead of making a separate call to set window masks, set them during creation. Also replaced the erroneous ButtonPress with ButtonPressMask. The former is meant as a event type while the letter is an event mask. They happen to have the same value, but this is not true for most events reported by TAAPArthur
tunalad
added a commit
to tunalad/herbe
that referenced
this pull request
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of making a separate call to set window masks, set them during
creation. Also replaced the erroneous ButtonPress with ButtonPressMask.
The former is meant as a event type while the letter is an event mask.
They happen to have the same value, but this is not true for most events