patch: dynamically updated the displayed notification#25
Open
TAAPArthur wants to merge 2 commits intodudik:masterfrom
Open
patch: dynamically updated the displayed notification#25TAAPArthur wants to merge 2 commits intodudik:masterfrom
TAAPArthur wants to merge 2 commits intodudik:masterfrom
Conversation
Moved the code to parse lines into its own method to make it easier to reuse for patches and less likely to cause conflicts. Also imports were sorted.
Notifications can now have an id and if a notification is already being displayed with that id, instead of creating a new notification, the message displayed will be updated. The implementation is based on message queues.
|
How is the message id set in practical use? I've compiled herbe with this port and looked through the C code. I don't see any way to set HERBE_ID with an arg. I've tried running multiple herbe calls from the same process or script and they still queue instead of updating. I might be missing something obvious here but I think basic documentation of this feature would be helpful. Thank you! PS just wanted to say thank you for your work on this patch, regardless of my ability to intuit it's implementation |
Author
|
@vv52 I don't actually use herbe anymore, but I believe I let the id be set with the env var |
tunalad
added a commit
to tunalad/herbe
that referenced
this pull request
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifications can now have an id and if a notification is already being displayed with that id, instead of creating a new notification, the message displayed will be updated. The implementation is based on message queues.
Depends on #24