recurly: AccountSubscriptions resource should inherit from Subscriptions

ducksboard · May 4, 2015 · 9f27f9b · 9f27f9b
1 parent dbf02ae
commit 9f27f9b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/libsaas/services/recurly/subscriptions.py b/libsaas/services/recurly/subscriptions.py
@@ -24,8 +24,7 @@ def get(self, state='live', cursor=None, per_page=None):
             or "past_due". A subscription will belong to more than one state.
         :vartype state: str
         """
-        params = base.get_params(('cursor', 'per_page'), locals())
-        params['state'] = state
+        params = base.get_params(None, locals())
         request = http.Request('GET', self.get_url(), params)
 
         return request, parsers.parse_xml
@@ -104,7 +103,7 @@ def postpone(self, next_renewal_date):
         return request, parsers.parse_empty
 
 
-class AccountSubscriptions(SubscriptionsBase):
+class AccountSubscriptions(Subscriptions):
 
     def create(self, *args, **kwargs):
         raise base.MethodNotSupported()

diff --git a/test/test_recurly.py b/test/test_recurly.py
@@ -56,7 +56,12 @@ def test_accounts(self):
         self.expect('GET', '/accounts/3/subscriptions')
 
         self.service.account(3).subscriptions().get(per_page=23)
-        self.expect('GET', '/accounts/3/subscriptions', {'per_page': 23})
+        self.expect(
+            'GET', '/accounts/3/subscriptions',
+            {'per_page': 23, 'state': 'live'})
+
+        self.service.account(3).subscriptions().get(state='active')
+        self.expect('GET', '/accounts/3/subscriptions', {'state': 'active'})
 
         self.service.account(3).billing_info().get()
         self.expect('GET', '/accounts/3/billing_info')