Skip to content

Conversation

@GuiltyDolphin
Copy link
Member

@GuiltyDolphin GuiltyDolphin commented Nov 28, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1200811069326255/task/1211820948344387?focus=true


Note

Disables tdsNextExperiment005 in overrides/android-override.json, overrides/ios-override.json, and overrides/macos-override.json.

Written by Cursor Bugbot for commit a8ea0ac. This will update automatically on new commits. Configure here.

github-actions bot pushed a commit that referenced this pull request Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Generated file outputs:

Time updated: Mon, 01 Dec 2025 15:05:04 GMT

legacy
23 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

6 files changed
  • v3/android-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/ios-config.json
  • v4/macos-config.json
--- v4/macos-config.json (and 5 other files)
+++ v4/macos-config.json
@@ -89790,9 +89790,9 @@
                         }
                     ]
                 },
                 "tdsNextExperiment005": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "rollout": {
                         "steps": [
                             {
                                 "percent": 100
latest
3 files changed
  • v5/android-config.json
  • v5/ios-config.json
  • v5/macos-config.json
--- v5/macos-config.json (and 2 other files)
+++ v5/macos-config.json
@@ -89790,9 +89790,9 @@
                         }
                     ]
                 },
                 "tdsNextExperiment005": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "rollout": {
                         "steps": [
                             {
                                 "percent": 100
11 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/windows-config.json

⚠️ File is identical

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

JSON approval analysis:

Time updated: Mon, 01 Dec 2025 15:05:13 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment005/state (replace)
  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)
  • v3/macos-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)
  • v4/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment005/state (replace)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)
  • v4/macos-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)
latest

❌ Manual Review Required

  • v5/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment005/state (replace)
  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)
  • v5/macos-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperiment005/state (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@GuiltyDolphin GuiltyDolphin added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 8203ccd Dec 2, 2025
17 of 27 checks passed
@GuiltyDolphin GuiltyDolphin deleted the gd-disable-tds-exp branch December 2, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants