Skip to content

Conversation

@hanyutang-sandra
Copy link
Contributor

@hanyutang-sandra hanyutang-sandra commented Oct 2, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211354430557015?focus=true

Description

Emergency override in case anything goes wrong.
Add remote feature override for subscriptionRestoreWidePixelMeasurement on both iOS & MacOS

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Note

Adds a disabled subscriptionRestoreWidePixelMeasurement feature override under privacyPro for iOS (min 7.191.0) and macOS (min 1.161.0).

  • Overrides:
    • iOS (overrides/ios-override.json):
      • Add privacyPro.features.subscriptionRestoreWidePixelMeasurement (state: disabled, minSupportedVersion: 7.191.0, description provided).
    • macOS (overrides/macos-override.json):
      • Add privacyPro.features.subscriptionRestoreWidePixelMeasurement (state: disabled, minSupportedVersion: 1.161.0, description provided).

Written by Cursor Bugbot for commit 18cc08a. This will update automatically on new commits. Configure here.

github-actions bot pushed a commit that referenced this pull request Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Generated file outputs:

Time updated: Thu, 09 Oct 2025 09:20:50 GMT

legacy
25 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -83215,10 +83215,12 @@
                 "paidAIChat": {
                     "state": "enabled",
                     "minSupportedVersion": "7.181.0"
                 },
-                "winBackOffer": {
-                    "state": "disabled"
+                "subscriptionRestoreWidePixelMeasurement": {
+                    "state": "disabled",
+                    "description": "Enables wide pixel measurement for Privacy Pro subscription restore events",
+                    "minSupportedVersion": "7.191.0"
                 }
             }
         },
         "privacyProtectionsPopup": {
2 files changed
  • v3/macos-config.json
  • v4/macos-config.json
--- v4/macos-config.json (and 1 other files)
+++ v4/macos-config.json
@@ -83213,10 +83213,12 @@
                 "paidAIChat": {
                     "state": "enabled",
                     "minSupportedVersion": "1.153.0"
                 },
-                "winBackOffer": {
-                    "state": "disabled"
+                "subscriptionRestoreWidePixelMeasurement": {
+                    "state": "disabled",
+                    "description": "Enables wide pixel measurement for Privacy Pro subscription restore events",
+                    "minSupportedVersion": "1.161.0"
                 }
             }
         },
         "privacyProtectionsPopup": {
latest
12 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -83215,10 +83215,12 @@
                 "paidAIChat": {
                     "state": "enabled",
                     "minSupportedVersion": "7.181.0"
                 },
-                "winBackOffer": {
-                    "state": "disabled"
+                "subscriptionRestoreWidePixelMeasurement": {
+                    "state": "disabled",
+                    "description": "Enables wide pixel measurement for Privacy Pro subscription restore events",
+                    "minSupportedVersion": "7.191.0"
                 }
             }
         },
         "privacyProtectionsPopup": {
v5/macos-config.json
--- v5/macos-config.json
+++ v5/macos-config.json
@@ -83213,10 +83213,12 @@
                 "paidAIChat": {
                     "state": "enabled",
                     "minSupportedVersion": "1.153.0"
                 },
-                "winBackOffer": {
-                    "state": "disabled"
+                "subscriptionRestoreWidePixelMeasurement": {
+                    "state": "disabled",
+                    "description": "Enables wide pixel measurement for Privacy Pro subscription restore events",
+                    "minSupportedVersion": "1.161.0"
                 }
             }
         },
         "privacyProtectionsPopup": {

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

JSON approval analysis:

Time updated: Thu, 09 Oct 2025 09:20:56 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)
  • v3/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)
  • v4/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)
  • v4/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)
latest

❌ Manual Review Required

  • v5/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)
  • v5/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/winBackOffer (remove)
    • /features/privacyPro/features/subscriptionRestoreWidePixelMeasurement (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@hanyutang-sandra hanyutang-sandra marked this pull request as ready for review October 3, 2025 09:24
@hanyutang-sandra hanyutang-sandra requested review from a team and daxtheduck as code owners October 3, 2025 09:24
@hanyutang-sandra hanyutang-sandra added the DO NOT MERGE Don't merge this branch unless directed label Oct 7, 2025
@hanyutang-sandra hanyutang-sandra removed the request for review from mallexxx October 7, 2025 08:52
samsymons
samsymons previously approved these changes Oct 9, 2025
…to htang/restore-subscription/Add-remote-config
github-actions bot pushed a commit that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Don't merge this branch unless directed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants