This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Deduplicate entries in History Menu #3831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209328755192084/f
Description:
This change updates History Menu to only display one item per URL per day,
which is in line with other mainstream browsers. This change remains behind historyView
feature flag and will only be made available when Full History View is released.
The grouping logic was extracted into HistoryGroupingProvider class where
it's made dependent on the feature flag state. Current behavior remains unchanged,
as evidenced by added unit tests.
Steps to test this PR:
historyView
feature flag and verify that History Menu only contains 1 item with URL A and 1 item with URL B (with the most recently visited on top).Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation