This repository was archived by the owner on Feb 24, 2025. It is now read-only.
VPN is sometimes stopped twice #3829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2025
samsymons
approved these changes
Feb 6, 2025
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 7, 2025
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209322889682604/f iOS PR: duckduckgo/iOS#3928 macOS PR: duckduckgo/macos-browser#3829 What kind of version bump will this require?: Patch ## Description Fixes an issue where the tunnel is being stopped twice.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Feb 7, 2025
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209322889682604/f macOS PR: duckduckgo/macos-browser#3829 BSK PR: duckduckgo/BrowserServicesKit#1213 **Description**: Fixes an issue where the tunnel is being stopped twice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209322889682604/f
iOS PR: duckduckgo/iOS#3928
BSK PR: duckduckgo/BrowserServicesKit#1213
Description:
Fixes an issue where the tunnel is being stopped twice.
Testing
The same step can be used to reproduce the original issue and test the fix.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation