This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Malicious Site Protection - Update BSK Ref #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mallexxx
approved these changes
Jan 27, 2025
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
4 times, most recently
from
5d0f3fc to
c8a91b7
Compare
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 29, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209158005098852 iOS PR: duckduckgo/iOS#3837 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: This PR exposes a method to fetch Malicious Site Protection Datasets and store last update dates for datasets.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
2 times, most recently
from
f23b284 to
21b8492
Compare
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 31, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209158005098852 iOS PR: duckduckgo/iOS#3837 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: This PR exposes a method to fetch Malicious Site Protection Datasets and store last update dates for datasets.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
from
21b8492 to
abb942c
Compare
7 tasks
alessandroboron
commented
Jan 31, 2025
| "revision" : "20b24085284b27a7c9a5257efa77b2f1cf59f893", | ||
| "version" : "232.1.1" | ||
| "branch" : "alessandro/malicious-site-protection-ios", | ||
| "revision" : "fb7c8ec55d29e5845db903b4404e7b00754b5a87" |
There was a problem hiding this comment.
I will update BSK ref, c-s-s and Privacy dashboard refs before merging it in
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 4, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209158005098852 iOS PR: duckduckgo/iOS#3837 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: This PR exposes a method to fetch Malicious Site Protection Datasets and store last update dates for datasets.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
from
cbc61aa to
923f511
Compare
mallexxx
reviewed
Feb 4, 2025
| @@ -149,7 +149,8 @@ public class MaliciousSiteProtectionManager: MaliciousSiteDetecting { | |||
| .visitSite, | |||
| .iframeLoaded, | |||
| .settingToggled, | |||
| .matchesApiTimeout: | |||
| .matchesApiTimeout, | |||
| .failedToDownloadInitialDataSets: | |||
There was a problem hiding this comment.
just to make sure: this used to send a Debug pixel when it was fired directly from BSK
There was a problem hiding this comment.
I thought that DebugEvent was useful when passing the error since it would add the domain and code automatically. Since we were sending this Pixel for a specific error I thought it wasn’t necessary to use DebugEvent. I found out that in PixelKit we check if the the event is a DebugEvent and append debug prefix. I’ve updated it.
else if let debugEvent = event as? DebugEvent {
// Is a Debug event not already prefixed
return "m_mac_debug_\(debugEvent.name)”
}
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 5, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209158005098852 iOS PR: duckduckgo/iOS#3837 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: This PR exposes a method to fetch Malicious Site Protection Datasets and store last update dates for datasets.
…e how many users are actually affected.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
from
8c5faa3 to
6681658
Compare
|
samsymons
approved these changes
Feb 6, 2025
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 6, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209233394358451/f iOS PR: duckduckgo/iOS#3901 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Major **Optional**: Tech Design URL: https://app.asana.com/0/481882893211075/1207273224076495/f **Description**: Add Malicious Site Protection feature to iOS.
alessandroboron
deleted the
alessandro/malicious-site-protection-ios-updates
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1209158005098852/f
Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f
Description:
Integrate Malicious Site Protection changes as part of the iOS work.
During iOS Ship Review we changed copy title for settings. I will double check if these changes needs to be integrated in this PR.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Before Merging
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation