Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPN App Exclusions remote feature-flag #3734

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add VPN App Exclusions remote feature-flag #3734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d651390
Adds the VPN App Exclusions remote feature flag
diegoreymendez Jan 15, 2025
a44198f
Updates BSK to 224.6.2
diegoreymendez Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adds the VPN App Exclusions remote feature flag
  • Loading branch information
@diegoreymendez
diegoreymendez committed Jan 15, 2025
commit d6513904e775b12c7d45d7a263834745d449526c
4 changes: 2 additions & 2 deletions DuckDuckGo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15365,8 +15365,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 224.6.1;
kind = revision;
revision = 985aca87fa862e753e26003c288c200e1676038f;
};
};
9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
3 changes: 1 addition & 2 deletions DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
"state" : {
"revision" : "58efae813cae03d71af87aab863af5c25a3a8a6e",
"version" : "224.6.1"
"revision" : "985aca87fa862e753e26003c288c200e1676038f"
}
},
{
Expand Down
7 changes: 7 additions & 0 deletions LocalPackages/FeatureFlags/Sources/FeatureFlags/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public enum FeatureFlag: String, CaseIterable {

case credentialsImportPromotionForExistingUsers

/// https://app.asana.com/0/0/1209150117333883/f
case networkProtectionAppExclusions

/// https://app.asana.com/0/72649045549333/1208231259093710/f
case networkProtectionUserTips

Expand All @@ -59,6 +62,8 @@ extension FeatureFlag: FeatureFlagDescribing {
return true
case .autofillPartialFormSaves:
return true
case .networkProtectionAppExclusions:
return true
case .debugMenu,
.sslCertificatesBypass,
.appendAtbToSerpQueries,
Expand Down Expand Up @@ -90,6 +95,8 @@ extension FeatureFlag: FeatureFlagDescribing {
return .remoteReleasable(.feature(.contextualOnboarding))
case .credentialsImportPromotionForExistingUsers:
return .remoteReleasable(.subfeature(AutofillSubfeature.credentialsImportPromotionForExistingUsers))
case .networkProtectionAppExclusions:
return .remoteDevelopment(.subfeature(NetworkProtectionSubfeature.appExclusions))
case .networkProtectionUserTips:
return .remoteDevelopment(.subfeature(NetworkProtectionSubfeature.userTips))
case .networkProtectionEnforceRoutes:
Expand Down
Loading