This repository was archived by the owner on Feb 24, 2025. It is now read-only.
update bsk for bookmarks view model changes #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Sep 24, 2023
…ove-hardcoded-message # By Fernando Bunn (4) and others # Via Sam Symons (2) and GitHub (1) * develop: (23 commits) Add run attempt to WORKFLOW_URL for reporting failed tests (#1671) Fix share in News (#1668) Set version to 1.57.1. Update BSK version for previous cherry-pick. The connection tester no longer disables on-demand (#1631) Home Button Implementation (#1649) Fix issue not setting maintenance date (#1663) Update DebugUI (#1659) Fix DBP on close notification (#1652) Ask for full disk access (NSAppDataUsageDescription) (#1639) Log user out of Sync when SyncOperation receives a HTTP 401 (#1666) fix first responder, improve logging, minor refactoring (#1657) Fix unit tests (#1662) Add child broker json files (#1660) Update HomePageContinueSetUpModel to not save a hardcoded Privacy Config reference (#1637) Update OpenSSL to 3.1.2000. (#1636) Onboarding flow fix for macOS Sonoma (#1655) Update profile address copy (#1658) Add WireGuard NetP Error Pixels (#1641) update bsk for bookmarks view model changes (#1640) ... # Conflicts: # DuckDuckGo/HomePage/Model/HomePageContinueSetUpModel.swift
samsymons
added a commit
that referenced
this pull request
Sep 24, 2023
…message' into sam/add-netp-messaging-support-part-2-add-remote-fetching # By Fernando Bunn (4) and others # Via Sam Symons (3) and GitHub (1) * sam/add-netp-messaging-support-part-1-remove-hardcoded-message: (23 commits) Add run attempt to WORKFLOW_URL for reporting failed tests (#1671) Fix share in News (#1668) Set version to 1.57.1. Update BSK version for previous cherry-pick. The connection tester no longer disables on-demand (#1631) Home Button Implementation (#1649) Fix issue not setting maintenance date (#1663) Update DebugUI (#1659) Fix DBP on close notification (#1652) Ask for full disk access (NSAppDataUsageDescription) (#1639) Log user out of Sync when SyncOperation receives a HTTP 401 (#1666) fix first responder, improve logging, minor refactoring (#1657) Fix unit tests (#1662) Add child broker json files (#1660) Update HomePageContinueSetUpModel to not save a hardcoded Privacy Config reference (#1637) Update OpenSSL to 3.1.2000. (#1636) Onboarding flow fix for macOS Sonoma (#1655) Update profile address copy (#1658) Add WireGuard NetP Error Pixels (#1641) update bsk for bookmarks view model changes (#1640) ... # Conflicts: # DuckDuckGo/HomePage/Model/HomePageContinueSetUpModel.swift # DuckDuckGo/Statistics/PixelEvent.swift # DuckDuckGo/Statistics/PixelParameters.swift # UnitTests/HomePage/ContinueSetUpModelTests.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205507330635027/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation