Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scheduler #1599

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Update Scheduler #1599

merged 5 commits into from
Sep 6, 2023

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Sep 5, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1203581873609357/1205429018807263/f

Description:

  • Start operations when the browser starts
  • Start operations when the user clicks on scan

Steps to test this PR:

  1. After creating a profile, check if we all the queued operations right away
  2. If we have a valid profile, check if we run all queued operations right away when starting the browser

@Bunn Bunn requested a review from jotaemepereira September 6, 2023 12:16
@Bunn
Merge branch 'develop' into bunn/dbp-scheduler
5366fea 
# Conflicts:
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionScheduler.swift
@Bunn Bunn marked this pull request as ready for review September 6, 2023 12:19
jotaemepereira
jotaemepereira approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@Bunn Bunn merged commit a7c5062 into develop Sep 6, 2023
@Bunn Bunn deleted the bunn/dbp-scheduler branch September 6, 2023 15:04
samsymons added a commit that referenced this pull request Sep 6, 2023
@samsymons
Merge branch 'develop' into sam/netp-waitlist
6324f75 
# By Fernando Bunn (3) and others
# Via GitHub
* develop:
  Updates sorting for Autofill UI Logins (#1596)
  Update Scheduler (#1599)
  PacketTunnelProvider crash buttons (#1597)
  swizzle WKNavigationAction.request, return empty request if nil (#1595)
  Better error messages in DBP result screen (#1590)
  Disables NetP when the waitlist is over (#1588)
  Settings Sync Provider with support for syncing Email Protection (#1565)
  Tie Find In Page to Bookmarks Bar (#1591)
  Move LoginItem to its own package (#1577)
  Update post merge failed task description (#1589)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift
#	DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionDebugUtilities.swift
#	DuckDuckGo/Waitlist/NetworkProtectionFeatureVisibility.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @jotaemepereira