Fix Xcode 15 compilation #1491
Merged
Fix Xcode 15 compilation #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
graeme
approved these changes
Aug 16, 2023
# By Sabrina Tardio (4) and others # Via Dominik Kapusta (3) and GitHub (1) * develop: Hotfix 1.52.2 (#1499) Set version to 1.52.2 (51) Update embedded files Hotfix: Add a dry-run feature flag to test incremental rollouts (#1498) fix bug that opens bookmarks in same tab (#1495) Sabrina/do not treat localhost as insecure (#1456) revise www dropping (#1426) save last visit as a full date (#1478) Change GHA project and section ID (#1488) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 17, 2023
Required: Task/Issue URL: https://app.asana.com/0/1203137811378537/1205173072817403/f iOS PR: duckduckgo/iOS#1918 macOS PR: duckduckgo/macos-browser#1491 What kind of version bump will this require?: Patch Optional: Tech Design URL: CC: Description: This PR updates the wireguard-apple repo version. The new WireGuard update includes a fix for the new linker in Xcode 15, which was preventing the macOS browser from compiling.
samsymons
added a commit
that referenced
this pull request
Aug 20, 2023
# By Dominik Kapusta (6) and others # Via Dominik Kapusta (6) and GitHub (1) * develop: (21 commits) Password autosaving and fireproof updates (#1489) Fix Xcode 15 compilation (#1491) Hotfix 1.52.2 (#1499) Set version to 1.52.2 (51) Update embedded files Hotfix: Add a dry-run feature flag to test incremental rollouts (#1498) fix bug that opens bookmarks in same tab (#1495) Sabrina/do not treat localhost as insecure (#1456) revise www dropping (#1426) save last visit as a full date (#1478) Change GHA project and section ID (#1488) Privacy reference tests adjusted for new Fire Button and Fireproofing (#1444) Pixels (#1483) Makes sure invite code flow changes are on develop (#1477) Appcast Management Tool (#1440) Bump version to 1.52.1 (50) Prevents the NetP popover from going out of screen bounds (#1485) Fix for autofill notes on catalina (#1481) Fix for autofill notes on catalina (#1481) Bump version to 1.52.0 (49) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/AppDelegate/AppDelegate.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1205173072817403/f
Tech Design URL:
CC:
Description:
This PR updates the version of WireGuard used by the app. This version of WireGuard was compiled with Go 1.21, which fixes issues with the new linker in Xcode 15.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation