Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cookie debug screen and diagnostic report generation #913

Merged
merged 9 commits into from
Jul 1, 2021

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 28, 2021

Task/Issue URL: https://app.asana.com/0/392891325557410/1200508873958867
Tech Design URL:
CC:

Description:

Add a new cookie debug screen and allow user to generate a diagnostics report.

Also small refactoring to clear cookies more effectively.

Steps to test this PR:

  1. Generally use the app, then go to settings > version > and click on the share icon.
  2. Use the activity sheet to save the report.
  3. Check it was created correctly and looks valid.
  4. Use the Fire Button.
  5. Ensure cookies cleared
  6. Generate another report and make sure it reflects the new state.

Device Testing:

  • iPhone X
  • iPad

OS Testing:

  • iOS 14

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job :)

@brindy
Copy link
Contributor Author

brindy commented Jul 1, 2021

Thanks @bwaresiak

@brindy brindy merged commit 73ebe2c into develop Jul 1, 2021
@brindy brindy deleted the brindy/fbfirebuild branch July 1, 2021 15:31
samsymons added a commit that referenced this pull request Jul 5, 2021
# By Christopher Brind (2) and others
# Via GitHub
* develop:
  Better reflect temporary unprotected status (#916)
  Fix build settings resolution for external developers (#880)
  add cookie debug screen, diagnostic report generation and optimise cookie deletion (#913)
  Update STYLEGUIDE.md (#917)
  Privacy reference unit tests for content blocker rules (#909)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/Debug.storyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants