Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar changes for NTP #3911

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Toolbar changes for NTP #3911

merged 7 commits into from
Feb 4, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 31, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1209282889760229/f

Description:
Change the toolbar icons on the new tab page

Steps to test this PR:

  1. Make sure you’re NOT set as internal
  2. Check that there are NO differences in the toolbar icons in both navigating or new tab page
  3. Make sure the back and forward buttons for navigation are working as expected and disabled in the new tab page
  4. Change to internal user
  5. Use the fire button, and navigate to a page. Make sure the back/forward buttons are working as expected
  6. Check if all other buttons in the toolbar are working as expected
  7. Use the fire button again.
  8. Check if all buttons in the toolbar are working as expected

Definition of Done (Internal Only):

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 9b2ca37

@Bunn Bunn requested a review from brindy February 3, 2025 17:53
@Bunn Bunn marked this pull request as ready for review February 3, 2025 17:53
brindy
brindy approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn
Browser menu (#3924)
9b2ca37 
Task/Issue URL:
https://app.asana.com/0/1204167627774280/1209282889760230/f
Tech Design URL:
CC:

**Description**:
Add new items to the new tab page browser menu. New Tab and AI Chat
@Bunn Bunn merged commit eca437b into main Feb 4, 2025
13 checks passed
@Bunn Bunn deleted the bunn/aichat/tabbar branch February 4, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @brindy