Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duck.ai bang #3863

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Handle duck.ai bang #3863

merged 1 commit into from
Jan 24, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 24, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1209233138534045/f
Tech Design URL:
CC:

Description:
Fix loop when opening duck.ai bang

Steps to test this PR:

  1. Host this site locally to test duck.ai and privacy pro
  2. Use this config file http://jsonblob.com/api/1332301684340350976
  3. Test if privacy pro links are working with both the hosted page above or directly opening duckduckgo.com/pro
  4. Check if using the bang “!ai test” opens duck.ai

Definition of Done (Internal Only):

@Bunn Bunn requested a review from afterxleep January 24, 2025 13:47
afterxleep
afterxleep approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn Bunn merged commit 52e210c into main Jan 24, 2025
21 checks passed
@Bunn Bunn deleted the bunn/aichat/fix-bang branch January 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterxleep afterxleep afterxleep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @afterxleep