Remove ATB from attribution pixel #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add is_reinstall value
ankushkushwaha
approved these changes
Nov 7, 2024
samsymons
reviewed
Nov 8, 2024
Comment on lines
90
to
+91
| let settings = AdAttributionReporterSettings(privacyConfigurationManager.privacyConfig) | ||
| let parameters = self.pixelParametersForAttribution(attributionData, attributionToken: settings.includeToken ? token : nil) | ||
| let token = settings.includeToken ? token : nil |
There was a problem hiding this comment.
It's not related to the changes in this PR, but is it possible that this Remote Config setting won't necessarily take effect at all times since the attribution call happens so early in the app's lifecycle, before the config may have updated?
There was a problem hiding this comment.
Yes, that's true, I'll reach out to you internally.
samsymons
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208686056380205/f
Tech Design URL:
CC:
Description:
Removes ATB cohort information from attribution pixel. Adds information about reinstall (returning user).
Steps to test this PR:
Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template