Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Autofill background access check with protected data check #2026

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 20, 2023

Task/Issue URL: https://app.asana.com/0/0/1205478345694790/f
Tech Design URL:
CC:

Description:
Replacing the Autofill background access check pixel with new protected data check pixel to reduce noise from false positives

Steps to test this PR:

  1. In AppDelegate add this code to application(_:performFetchWithCompletionHandler):
    let manager = SecureVaultManager(includePartialAccountMatches: true, tld: AppDependencyProvider.shared.storageCache.tld) mainViewController?.currentTab?.secureVaultManagerIsEnabledStatus(manager, forType: .password)
  2. Testing on device, run up the app and visit any website
  3. Check that pixel m_secure-vault_is-enabled-checked_when-enabled-and-data-protected does not fire while the site is loading
  4. Lock the phone screen and wait a few seconds
  5. Via XCode Debug menu, simulate a background fetch which will trigger the code in step 1.
  6. Confirm that when there is no access to protected data, the new pixel is fired

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from bwaresiak September 20, 2023 14:46
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amddg44 amddg44 merged commit 89fc56b into develop Sep 22, 2023
10 checks passed
@amddg44 amddg44 deleted the anya/autofill-protected-data-check branch September 22, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants