Replace Autofill background access check with protected data check #2026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205478345694790/f
Tech Design URL:
CC:
Description:
Replacing the Autofill background access check pixel with new protected data check pixel to reduce noise from false positives
Steps to test this PR:
AppDelegate
add this code toapplication(_:performFetchWithCompletionHandler)
:let manager = SecureVaultManager(includePartialAccountMatches: true, tld: AppDependencyProvider.shared.storageCache.tld) mainViewController?.currentTab?.secureVaultManagerIsEnabledStatus(manager, forType: .password)
m_secure-vault_is-enabled-checked_when-enabled-and-data-protected
does not fire while the site is loadingCopy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template