Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow delete from edit screen #2005

Merged
merged 24 commits into from
Sep 21, 2023
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 12, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1205194478809824/f
Tech Design URL:
CC:

Description:

Adds:

  • Delete button to edit bookmark screen
  • Enable/disable Save button on add/edit login screen
  • Updated trash icon

Steps to test this PR:

Edit Bookmark:

  1. Add some bookmarks.
  2. Edit a bookmark.
  3. Tap delete
  4. Click OK
  5. Check that bookmark is deleted
  6. Create a favorite
  7. Repeat above test, check favorite is deleted
  8. Repeat above test with favorite and tap undo on the action message. Check that bookmark/favorite is returned to correct folder / favorite position.
  9. Repeat undo test but close the bookmarks view controller before tapping undo.

Add/Edit Login:

  1. Manually add a new login, save button should be visible but disabled
  2. Add some text to at least one field (try each field) and the save button should enable
  3. Edit an existing login, same logic should apply - only when at least one field has text should the save button be enabled

Trash Icon:

  1. Go to bookmarks list
  2. Swipe left on a bookmark to show delete icon
  3. Should be updated Trash icon

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy marked this pull request as ready for review September 15, 2023 09:40
@brindy brindy requested a review from amddg44 September 15, 2023 09:40
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against b6006c7

@brindy brindy merged commit 7f7eb32 into develop Sep 21, 2023
8 checks passed
@brindy brindy deleted the brindy/allow-delete-from-edit-screen branch September 21, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants