NetP now clears the auth token in the extension + small bug fix. #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 5, 2023
…a small bug with a callback (#491) Task/Issue URL: https://app.asana.com/0/0/1205416442924462/f iOS PR: duckduckgo/iOS#1975 macOS PR: duckduckgo/macos-browser#1588 What kind of version bump will this require?: Patch ## Description When the extension receives a `resetAllState` message, it's now properly cleaning the stored auth token. Executes a callback that was missing.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 5, 2023
Task/Issue URL: https://app.asana.com/0/0/1205416442924461/f BSK PR: duckduckgo/BrowserServicesKit#491 iOS PR: duckduckgo/iOS#1975 ## Description Disables NetP when the waitlist is over. Known limitation: we're not disabling NetP if the user interacts with the menu agent. This is something to discuss separately.
samsymons
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 8, 2023
Task/Issue URL: https://app.asana.com/0/0/1205416442924461/f BSK PR: duckduckgo/BrowserServicesKit#491 iOS PR: duckduckgo/iOS#1975 ## Description Disables NetP when the waitlist is over. Known limitation: we're not disabling NetP if the user interacts with the menu agent. This is something to discuss separately. # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionUI/Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205416442924463/f
BSK PR: duckduckgo/BrowserServicesKit#491
macOS PR: duckduckgo/macos-browser#1588
Description
Integrates some changes from BSK that make NetP now clear the auth token in the extension when
resetAllStateis called.Also fixes a small bugfix with a callback not being called when it should.
Testing
Just make sure this builds and NetP connects fine. There should really be no visible effect in using this for iOS.
Internal references:
Software Engineering Expectations
Technical Design Template