Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS InContext Email Protection Signup #1839

Merged
merged 44 commits into from
Aug 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
9836b0d
Initial basic email promotion prompt modal flow
amddg44 Jul 5, 2023
eb95b70
Update to trigger autofill didRequestAliasAndRequiresUserPermission i…
amddg44 Jul 10, 2023
b938315
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Jul 11, 2023
509cd1e
Navigation styling & button state handling
amddg44 Jul 11, 2023
a355794
Flow update to trigger autofill replyHandler at end of incontext sign…
amddg44 Jul 11, 2023
6072435
Improvement to email protection sign in flow when in the modal sign u…
amddg44 Jul 17, 2023
421370c
Reset of Email Protection InContext SignUp userDefaults added to app …
amddg44 Jul 17, 2023
9f470b0
Email Protection InContext Signup strings added
amddg44 Jul 17, 2023
3f39652
Pass in completion handler on init
amddg44 Jul 17, 2023
e67df2c
Blocking alert dialog for when attempting to exit the sign up flow early
amddg44 Jul 17, 2023
ef113a4
Replacing inContextSignup notification trigger with delegate method
amddg44 Jul 17, 2023
ce27c8e
Removed un-needed delegate + some general tidy up
amddg44 Jul 17, 2023
d01c27b
New Email signup prompt view controller
amddg44 Jul 17, 2023
d9a37b7
BSK version bump
amddg44 Jul 17, 2023
a35fa41
Merge branch 'develop' into anya/ios-incontext-email-promotion
amddg44 Jul 20, 2023
7566965
Reset Email InContext signup option added
amddg44 Jul 20, 2023
7d4b010
New Email address prompt
amddg44 Jul 27, 2023
9e1acf2
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Jul 31, 2023
6d1642f
Email prompt moved out of TabViewController.swift
amddg44 Jul 31, 2023
53e6def
Update for SecureVaultStorage
amddg44 Jul 31, 2023
5f4f377
Design review feedback changes
amddg44 Jul 31, 2023
72a2dac
Set BSK, Autofill
amddg44 Jul 31, 2023
002f6f7
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Jul 31, 2023
5075a3e
iPhone SE custom margin
amddg44 Aug 1, 2023
fbfd99b
BSK bump
amddg44 Aug 1, 2023
c140da9
BSK bump
amddg44 Aug 1, 2023
4ba80a9
Layout constants
amddg44 Aug 1, 2023
db0f163
BSK bump
amddg44 Aug 1, 2023
4383464
Tidy up
amddg44 Aug 1, 2023
078794d
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Aug 3, 2023
aca7aca
Updates from duck address changes merge
amddg44 Aug 4, 2023
03a311c
Address PR feedback
amddg44 Aug 8, 2023
cface52
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Aug 8, 2023
588895d
Bump BSK
amddg44 Aug 8, 2023
89a51e2
swiftlint
amddg44 Aug 8, 2023
cb309d8
Translations for InContext email protection (#1903)
amddg44 Aug 15, 2023
c289b84
iOS InContext Email Protection pixels (#1902)
amddg44 Aug 15, 2023
2548b1d
iOS InContext Email Protection promotion config updates (#1901)
amddg44 Aug 15, 2023
91cd3bb
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Aug 15, 2023
0b1ca4b
BSK bump
amddg44 Aug 15, 2023
ea158c1
Merge remote-tracking branch 'origin/develop' into anya/ios-incontext…
amddg44 Aug 24, 2023
9e12b4d
BSK bump
amddg44 Aug 24, 2023
f394af4
BSK bump
amddg44 Aug 24, 2023
31c817b
Set to BSK release 75.1.0
amddg44 Aug 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update for SecureVaultStorage
  • Loading branch information
amddg44 committed Jul 31, 2023
commit 53e6def0f23be849eeb2f9bfb1aa384b1148356e
7 changes: 6 additions & 1 deletion DuckDuckGo/EmailSignupViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import Networking
import UserScript
import WebKit
import DesignResourcesKit
import SecureStorage

// swiftlint:disable file_length
class EmailSignupViewController: UIViewController {
Expand Down Expand Up @@ -377,7 +378,7 @@ extension EmailSignupViewController: EmailManagerRequestDelegate {

extension EmailSignupViewController: SecureVaultManagerDelegate {

func secureVaultInitFailed(_ error: SecureVaultError) {
func secureVaultInitFailed(_ error: SecureStorageError) {
SecureVaultErrorReporter.shared.secureVaultInitFailed(error)
}

Expand Down Expand Up @@ -413,6 +414,10 @@ extension EmailSignupViewController: SecureVaultManagerDelegate {
return false
}

func secureVaultManagerShouldSaveData(_: BrowserServicesKit.SecureVaultManager) -> Bool {
return false
}

func secureVaultManager(_: SecureVaultManager, didRequestAuthenticationWithCompletionHandler: @escaping (Bool) -> Void) {
// no-op
}
Expand Down