wire up sync account creation and recovery to backend #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ayoy
approved these changes
Mar 28, 2023
| @@ -68,22 +91,24 @@ extension SyncSettingsViewController: Themable { | |||
| extension SyncSettingsViewController: SyncManagementViewModelDelegate { | |||
|
|
|||
| func createAccountAndStartSyncing() { | |||
| print(#function) | |||
There was a problem hiding this comment.
This should be removed I think?
| showDeviceConnected() | ||
| return true | ||
| func syncCodeEntered(code: String) async -> Bool { | ||
| print(#function, code) |
There was a problem hiding this comment.
One more unneeded print statement
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
brindy
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 28, 2023
Required: Task/Issue URL: https://app.asana.com/0/414235014887631/1204209043038910/f iOS PR: duckduckgo/iOS#1561 macOS PR: duckduckgo/macos-browser#1051 What kind of version bump will this require?: Major/Minor/Patch Optional: Tech Design URL: https://app.asana.com/0/481882893211075/1203453172147755/f CC: Description: Updates to use JSON base sync code format. Steps to test this PR: 1/ Smoke test of iOS and macOS create account, validate the QRCode looks like valid JSON by copying the text and pasting into https://www.base64decode.org/ 2/ On iOS, turn on Sync, tap "not now" for adding a new device, then copy the code and "recover" the account on macOS Tap turn on Sync, then tap Turn On Sync again, then tap Add Device, then paste in the code 3/ Create an account on macoS, then copy the code and "recover" account on iOS. This can be done in two ways: Turn on sync, tap next, tap add device, scan the code showing in the macOS app Turn on sync, tap next, tap add device, copy the code from macOS and paste the code showing in the macOS app
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
samsymons
added a commit
that referenced
this pull request
Apr 4, 2023
# By Alexey Martemyanov (3) and others # Via amddg44 (2) and others * develop: add sync connect (#1604) Release 7.72.8 (#1611) Fix autoconsent after UserScripts reload (#1608) Manage Favorites from Favorites Overlay (#1539) Fix swiftlint violations (#1610) Remove codeowner (#1607) Feature flagging with autofill subfeatures (#1555) Stop assignment to experiment variants but keep existing running (#1598) Fix settings layout issue with "About" header too close to previous section (#1576) re-enable blanket rule (#1600) Add codeowners file (#1581) Bump json5 from 1.0.1 to 1.0.2 (#1430) Update BSK with autofill 6.4.3 (#1573) Autofill change to sorting algorithm for displaying logins (#1513) Fix `PrivacyIconView` Accessibility Traits Refresh (#1557) Update SwiftLint to 0.51.0 (#1591) move AppHTTPSUpgradeStore to BSK (#1549) Properly send compile rules result pixel including app state (#1574) wire up sync account creation and recovery to backend (#1561) Update BSK with autofill 6.4.1 (#1560) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
samsymons
added a commit
that referenced
this pull request
Apr 5, 2023
* develop: (25 commits) add sync connect (#1604) Release 7.72.8 (#1611) Fix autoconsent after UserScripts reload (#1608) Manage Favorites from Favorites Overlay (#1539) Fix swiftlint violations (#1610) Remove codeowner (#1607) Feature flagging with autofill subfeatures (#1555) Stop assignment to experiment variants but keep existing running (#1598) Fix settings layout issue with "About" header too close to previous section (#1576) re-enable blanket rule (#1600) Add codeowners file (#1581) Bump json5 from 1.0.1 to 1.0.2 (#1430) Update BSK with autofill 6.4.3 (#1573) Autofill change to sorting algorithm for displaying logins (#1513) Fix `PrivacyIconView` Accessibility Traits Refresh (#1557) Update SwiftLint to 0.51.0 (#1591) move AppHTTPSUpgradeStore to BSK (#1549) Properly send compile rules result pixel including app state (#1574) wire up sync account creation and recovery to backend (#1561) Update BSK with autofill 6.4.1 (#1560) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1204209043038910/f
Tech Design URL:
CC:
Description:
Connects the UI to the backend via BSK.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM