Updates to Fireproofing dialogue and Settings #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
requested review from
brindy,
Bunn,
bwaresiak,
jaceklyp,
samsymons and
THISISDINOSAUR
as code owners
amddg44
removed request for
brindy,
samsymons,
Bunn,
THISISDINOSAUR,
jaceklyp and
bwaresiak
amddg44
changed the title
miasma13
reviewed
Feb 2, 2022
samsymons
added a commit
that referenced
this pull request
Feb 4, 2022
* develop: Fix a typo in the waitlist copy. (#1045) Only reset lastUpgradedURL if loading new URL comes from the user action (#1046) Updates to Fireproofing dialogue and Settings (#1044) Remove CODEOWNERS. Fix bookmarks edit button when data source empty (#1043) Fix Fingerprinting UI tests. (#1041) Bump version number Add JS Alert block button (#1039) Update CONTRIBUTING.md Fix back button doesn't trigger back action (#1027) Set version to 7.65.6. Widget crash fix (#1038) Add keychain items to debug menu (#1037) Brad/tracking params (#1016) Prevent repeated completions. Respect feature flags (#1036) Update release notes Change build version to 0 Update version number Add Anya to CODEOWNERS. (#1033) fix AMP related crash (#1032)
Bunn
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Fireproof copy update for alert * Fireproof copy updates to Fireproof Settings * Additional Fireproof copy update * Translations updated * Multiline support for Fireproof toggle label to accommodate long translations * Contents of Localizable.strings fixed
samsymons
added a commit
that referenced
this pull request
Feb 8, 2022
# By Sam Symons (6) and others # Via Bartek Waresiak (2) and others * develop: Fix a typo in the waitlist copy. (#1045) Only reset lastUpgradedURL if loading new URL comes from the user action (#1046) Updates to Fireproofing dialogue and Settings (#1044) Remove CODEOWNERS. Fix bookmarks edit button when data source empty (#1043) Fix Fingerprinting UI tests. (#1041) Bump version number Add JS Alert block button (#1039) Update CONTRIBUTING.md Fix back button doesn't trigger back action (#1027) Set version to 7.65.6. Widget crash fix (#1038) Add keychain items to debug menu (#1037) Brad/tracking params (#1016) Prevent repeated completions. Respect feature flags (#1036) # Conflicts: # DuckDuckGo/UserText.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1201479811018830/f
Tech Design URL:
CC: @miasma13
Description:
This PR updates copy for Fireproof dialogue and Settings
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM