Remove noatb.css. #2312
Merged
Remove noatb.css. #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not using this CSS rule for extension detection anymore. Removing it fixes a race condition on extension install in Firefox.
sammacbeth
force-pushed
the
sam/remove-noatb
branch
from
c478412 to
6750c61
Compare
sammacbeth
force-pushed
the
sam/remove-noatb
branch
from
01b7c8a to
ca3b59f
Compare
sammacbeth
force-pushed
the
sam/remove-noatb
branch
from
ca3b59f to
4303454
Compare
|
@sammacbeth code looks good, but I couldn't get the post-install page to open. I'm probably doing something wrong though with the build/install process, as I haven't tested a dev build in a long time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
We're not using this CSS rule for extension detection anymore. Removing it fixes a race condition on extension install in Firefox.
Asana: https://app.asana.com/0/892838074342800/1205807960803986/f
Steps to test this PR:
natbvalue in the URL bar.about:debuggingand install the extension.atbvalue matchesnatbfrom step 3.