Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracker-allowlist subdomain matching #2282

Merged

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Oct 20, 2023

Reviewer:

Description:

https://app.asana.com/0/0/1205728706026115/f

The current matching of the 'domains' field of the tracker allowlist matched only eTLD+1. This PR adds subdomain matching.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@sammacbeth sammacbeth requested a review from kzar October 20, 2023 08:12
@sammacbeth sammacbeth marked this pull request as ready for review October 24, 2023 08:15
@sammacbeth sammacbeth force-pushed the sam/tracker-allowlist-subdomain branch from c302905 to c9fbef6 Compare October 24, 2023 08:23
package.json Outdated Show resolved Hide resolved
@sammacbeth sammacbeth force-pushed the sam/tracker-allowlist-subdomain branch from 3d87c2e to f4afb8f Compare October 24, 2023 14:10
@jonathanKingston jonathanKingston merged commit 0964410 into duckduckgo:main Oct 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants