Force set list values to false on Site initialization #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recreating a Site object with an existing TabState object, we were not resetting allow- and deny-list values when the URL changed. This means that the an allowlisted site would have that state persisted to other sites after a navigation. We can fix this by force setting the value to false when creating the Site object.
jonathanKingston
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recreating a Site object with an existing TabState object, we were not resetting allow- and deny-list values when the URL changed. This means that an allowlisted site would have that state persisted to other sites after a navigation.
We can fix this by force setting the value to false when creating the Site object.