Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also treat new tab page with ATB params as 'special' #2119

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Also treat new tab page with ATB params as 'special' #2119

merged 1 commit into from
Jul 21, 2023

Conversation

sammacbeth
Copy link
Collaborator

Description:

  • After clearing tabs from with the fire button, the privacy dashboard was showing a 'normal' view, rather than the 'special page' view we expect for the new tab page.
  • Due to the way the redirect to the NTP happens in this case, we were picking up the URL with ATB params included.
  • Our 'special page' detection code expected an exact match, so this URL wasn't detected as 'special'.
  • This PR makes the matching accept parameters on the NTP url.

@sammacbeth sammacbeth requested a review from GioSensation July 20, 2023 07:14
GioSensation
GioSensation approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sammacbeth sammacbeth merged commit 9185137 into duckduckgo:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioSensation GioSensation GioSensation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @GioSensation