Migrate legacy reference test to node test runner #2118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
browserify
to build, primarily because they usejsdom
.jsdom
in the browser (the normal unit-test environment) is a hack.jasmine
.jasmine
), these tests can be written in the same way as the normal unit-tests. The run context (node
vsbrowser
) depends on which folder they are in under theunit-tests
dir:unit-test/node
-> run innode
, other folders are run in the browser.Requires duckduckgo/content-scope-scripts#643 and duckduckgo/privacy-reference-tests#104 for tests to pass.