Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only ship sourcemaps in dev builds #2110

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Only ship sourcemaps in dev builds #2110

merged 1 commit into from
Jul 13, 2023

Conversation

sammacbeth
Copy link
Collaborator

Sourcemaps tip the size of background.js to over 4mb, which the Firefox addon store refuses to analyze. Let's revert to only including source maps in dev builds.

jonathanKingston
jonathanKingston approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM can we explore lighter minification instead in the future?

@sammacbeth
Copy link
Collaborator Author

@jonathanKingston The sourcemaps are 2.8M of the bundle size. We could use --minify to get the bundle, with sourcemaps, down to 3.3M as an alternative.

@sammacbeth sammacbeth merged commit 970b3eb into duckduckgo:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanKingston jonathanKingston jonathanKingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @jonathanKingston