Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused modules #2096

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Jul 7, 2023

Reviewer:

Description:

  • brfs: removing this from legacy unit-test build doesn't have an effect, so we can safely remove.
  • jasmine-core: Moved to be a transitive dependency of jasmine.
  • load-grunt-tasks: Only used in privacy-grade submodule.
  • is-plain-object: Unused.
  • seedrandom: Unused
  • underscore: Unused.

@sammacbeth sammacbeth force-pushed the 202307/module-cleanup branch from f0f3138 to 564164e Compare July 7, 2023 07:45
@sammacbeth sammacbeth marked this pull request as ready for review July 7, 2023 08:00
@sammacbeth sammacbeth requested a review from kzar July 7, 2023 08:00
 - @types/puppeteer
 - brfs
 - jasmine-core
 - load-grunt-tasks
 - seedrandom
 - underscore
@sammacbeth sammacbeth force-pushed the 202307/module-cleanup branch from e850667 to 099b0bb Compare July 7, 2023 15:53
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sammacbeth sammacbeth merged commit eae49df into duckduckgo:main Jul 10, 2023
@sammacbeth sammacbeth deleted the 202307/module-cleanup branch July 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants