Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not strip subdomains when referrer trimming #2053

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

sammacbeth
Copy link
Collaborator

We're removing the eTLD+1 referrer trimming feature for breakage and party reasons.

@sammacbeth sammacbeth requested a review from SlayterDev June 14, 2023 08:08
Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but unit tests are failing here.

@sammacbeth sammacbeth force-pushed the 202306/referrer-trimming branch from 3f41b38 to d937845 Compare June 23, 2023 15:41
@sammacbeth sammacbeth merged commit 6be3e70 into duckduckgo:main Jun 23, 2023
@sammacbeth sammacbeth deleted the 202306/referrer-trimming branch June 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants