Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill shown should not update lastUsed #1891

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

GioSensation
Copy link
Member

Reviewer: @sixers

Description:

No longer update lastUsed when firing the autofill shown pixel.

Steps to test this PR:

  1. Open the background script devtools on the Network tab
  2. With autofill enabled, open the tooltip on a page, for example https://privacy-test-pages.glitch.me/autofill/modal.html
  3. Note the duck_address_last_used parameter (it should not be today)
  4. Open the tooltip again. The parameter should stay the same
  5. Now select an address
  6. Open the tooltip again. The parameter should now be set to today

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation GioSensation self-assigned this Apr 12, 2023
shared/js/background/email-utils.js Outdated Show resolved Hide resolved
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation
Copy link
Member Author

@jonathanKingston We need approval from someone with write access. By the way, can you give write access to @sixers so we can have faster loops in the future or should we go through IO?

The failing tests are also failing on main so they're not related.

@GioSensation GioSensation merged commit dff0490 into main Apr 12, 2023
@GioSensation GioSensation deleted the ema/fix-autofill-show-tooltip-updating-lastused branch April 12, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants