Skip to content

[Hackday] Hover SummarizationRunning on integration #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

[Hackday] Hover SummarizationRunning on integration #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff623a0
Running on integration
mgurgel Jun 12, 2025
e15adf1
Running on integration
mgurgel Jun 12, 2025
0e895df
Removed extra console.log
mgurgel Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions injected/entry-points/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ function generateConfig() {
'apiManipulation',
'duckPlayer',
'duckPlayerNative',
'hoverSummarization',
],
},
};
Expand Down
81 changes: 81 additions & 0 deletions injected/integration-test/test-pages/hover-summarization/test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<title>Hover Summarization Test Page</title>
<style>
*, *:before, *:after {
box-sizing: border-box;
}
body {
max-width: 100%;
margin-left: 0;
margin-right: 0;
}
</style>
</head>
<body>

<main>
This is a test page for hover summarization.
<ul>
<li><a href="https://www.duckduckgo.com">DuckDuckGo</a></li>
<li><a href="https://www.youtube.com">YouTube</a></li>
<li><a href="https://www.wikipedia.org">Wikipedia</a></li>
<li><a href="https://www.reddit.com">Reddit</a></li>
<li><a href="https://www.twitter.com">Twitter</a></li>
<li><a href="https://www.facebook.com">Facebook</a></li>
<li><a href="https://www.instagram.com">Instagram</a></li>
</ul>
</main>

<script>
(async () => {
settings = {
"unprotectedTemporary": [],
"features": {
"hoverSummarization": {
"state": "enabled",
"exceptions": [],
"settings": {}
}
}
}

if (!new URLSearchParams(location.search).has('preview')) {
console.log('Not previewing');
return;
}
const platformName = new URLSearchParams(window.location.search).get('platform') || 'macos';
const locale = new URLSearchParams(window.location.search).get('locale') || 'en';

await import("/build/contentScope.js").catch(console.error);

const initArgs = {
detail: {
debug: true,
locale: locale,
platform: {
name: platformName,
},
site: {
domain: location.hostname,
isBroken: false,
allowlisted: false,
enabledFeatures: [
'hoverSummarization',
]
},
featureSettings: {
hoverSummarization: settings.features.hoverSummarization.settings,
}
}
};
console.log('Dispatching event content-scope-init-args', initArgs);
document.dispatchEvent(new CustomEvent('content-scope-init-args', initArgs));
})();
</script>

</body>
</html>
12 changes: 10 additions & 2 deletions injected/src/features/hover-summarization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@ export default class HoverSummarization extends ContentFeature {
if (!this.messaging) {
throw new Error('cannot operate link hover summarization without a messaging backend');
}
this.injectHoverSummarization();

if (document.readyState === 'loading') {
console.log('Injecting hover summarization on DOMContentLoaded');
document.addEventListener('DOMContentLoaded', this.injectHoverSummarization.bind(this), { once: true });
} else {
console.log('Injecting hover summarization immediately');
this.injectHoverSummarization();
}
}

injectHoverSummarization() {
Expand Down Expand Up @@ -44,10 +51,11 @@ export default class HoverSummarization extends ContentFeature {
document.addEventListener('keydown', keydownHandler);

linksList.forEach((link) => {
console.log('Adding mouseenter listener to link', link);
link.addEventListener('mouseenter', () => {
currentHoveredLink = link;
console.log('Link Hovered. Press Shift to activate summarization.');
currentHoverTimer = setTimeout(() => {
console.log('Link Hovered. Press Shift to activate summarization.');
}, 500);
});

Expand Down
Loading