Optimize first load of Content Rule Lists #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2023
bwaresiak
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 18, 2023
Task/Issue URL: https://app.asana.com/0/414709148257752/1204978316870813/f Tech Design URL: CC: **Description**: See duckduckgo/BrowserServicesKit#406
bwaresiak
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 18, 2023
Task/Issue URL: https://app.asana.com/0/414709148257752/1204978316870813/f Tech Design URL: CC: Description: See duckduckgo/BrowserServicesKit#406
samsymons
added a commit
that referenced
this pull request
Jul 20, 2023
* main: Fix publisher, add option to override internal user state in debug (#422) Removes unused code and makes some other code platform specific (#419) Optimize first load of Content Rule Lists (#406) Automatically add the PR link to the Asana task (#311) NetP: Move bundle prefix to x-platform code (#418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414709148257752/1204978316870813/f
iOS PR:
macOS PR:
What kind of version bump will this require?: Patch
Description:
Speed up initial setup of the Content Blocking stack.
Steps to test this PR:
Happy path testing - content blocking smoke tests along with attribution ones.
Removal of WebKit-cached rules lists should fall back to Last Compiled Rules cache.
Removal of WebKit-cached rules and Last Compiled Rules cache should just compile and block navigation till it's done.
Changing TDS etag (must be done manually) should cause miss of initial lookup but fallback to Last Rules.
Changing current rules set (e.g. by changing the name of the rule list) should fail both the WebKit and Last Compiled caches and result in recompilation.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template