Skip to content

Commit

Permalink
Fixes an issue when uninstalling the VPN over UDS, where the menu app…
Browse files Browse the repository at this point in the history
… wouldn't quit (#866)

Task/Issue URL: https://app.asana.com/0/1207603085593419/1207659744300515/f

iOS PR: duckduckgo/iOS#2999
macOS PR: duckduckgo/macos-browser#2911

What kind of version bump will this require?: Major/Minor/Patch

## Description

Fixes stopping the VPN agent after uninstalling the VPN in App Store builds.
  • Loading branch information
diegoreymendez authored Jun 27, 2024
1 parent 27b2330 commit f815750
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public enum VPNCommand: Codable {
case sendTestNotification
case uninstallVPN
case disableConnectOnDemandAndShutDown
case quitAgent
}

public enum ExtensionRequest: Codable {
Expand Down
3 changes: 3 additions & 0 deletions Sources/NetworkProtection/PacketTunnelProvider.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,9 @@ open class PacketTunnelProvider: NEPacketTunnelProvider {
case .uninstallVPN:
// Since the VPN configuration is being removed we may as well reset all state
handleResetAllState(completionHandler: completionHandler)
case .quitAgent:
// No-op since this is intended for the agent app
break
}
}

Expand Down

0 comments on commit f815750

Please sign in to comment.