Replace yellow pill images for custom view#7658
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| app:primaryText="Settings List Item with New Pill" | ||
| app:pillIcon="newPill" /> | ||
| app:pillIcon="true" | ||
| app:pillText="Beta" /> |
There was a problem hiding this comment.
Wrong pill text "Beta" for "New Pill" item
Medium Severity
The item settingsListItemWithNewTag with primaryText="Settings List Item with New Pill" has app:pillText="Beta" instead of "New". Before the change, this used app:pillIcon="newPill", so the replacement text should be "New" to maintain the same visual appearance. This causes incorrect UI labeling in the settings preview.
| app:secondaryText="Checked in disabled state" | ||
| app:showBetaPill="true" | ||
| app:pillIcon="true" | ||
| app:pillText="Whatever" |
There was a problem hiding this comment.
Test placeholder "Whatever" left in pill text
Low Severity
The pillText attribute is set to "Whatever" which appears to be a test or placeholder value. All other similar items in the diff use proper values like "Beta". While this is in a design system preview layout, it creates an inconsistent and unprofessional appearance during testing.
|
|
||
| </LinearLayout> | ||
| app:pillIcon="true" | ||
| app:pillText="Beta"/> |
There was a problem hiding this comment.
Wrong pill text "Beta" for "New Pill" item
Medium Severity
The item oneLineListItemWithNewPill with primaryText="Item with New Pill" has app:pillText="Beta" instead of "New". Before this change, the item used app:showNewPill="true" which displayed a "New" pill image. The replacement text should be "New" to maintain the same visual appearance.
3 participants
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213011616457504?focus=true
Description
Replace pillIcon images in ListItem components for the new custom view where we can set text as string
Steps to test this PR
No UI changes
Note
Medium Risk
Touches shared design-system list item components and their XML attributes, which may break existing layouts relying on the removed
showBetaPill/showNewPilland enum-basedpillIconAPIs. UI regressions are possible if pill visibility/text or constraint changes behave differently across screens.Overview
Replaces static Beta/New pill
ImageViewassets inOneLineListItem,TwoLineListItem, andSettingsListItemwith theDaxYellowPillcustom text view, allowing the pill label to be provided as a string.Unifies and changes the public XML API by removing
showBetaPill/showNewPilland the enum-basedpillIcon, replacing them withpillIcon(boolean) plus newpillTextacross list item styleables; corresponding sample/preview layouts are updated accordingly, and the legacy pill-handling helpers inDaxListItemare removed.Written by Cursor Bugbot for commit 78be03b. This will update automatically on new commits. Configure here.