-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interstitial search #719
Conversation
# Conflicts: # app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
…l apps coroutine when new query arrives
# Conflicts: # app/src/main/res/values/string-untranslated.xml
# Conflicts: # app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
Over to you for review @CDRussell. Ping me if you want to zoom to go over it! |
...c/main/java/com/duckduckgo/app/browser/autocomplete/BrowserAutoCompleteSuggestionsAdapter.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome! all scenarios tested, and all comments optional
one question; did we deliberately decide to omit bookmarks from the interstitial search?
app/src/main/java/com/duckduckgo/app/di/SystemComponentsModule.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/statistics/pixels/Pixel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/DeviceAppLookup.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments but LGTM
...c/main/java/com/duckduckgo/app/browser/autocomplete/BrowserAutoCompleteSuggestionsAdapter.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/DeviceAppSuggestionsAdapter.kt
Outdated
Show resolved
Hide resolved
Thanks for the great feedback @CDRussell & @malmstein! |
First off, very strong work here! 👍
|
Thanks @JeffAment! Yes, I was a little overzealous in using the "view model" as a source of truth 😬I have a task to clean it up over the next few days, hope I can sneak it into the next release. |
Task/Issue URL: https://app.asana.com/0/361428290920652/1154054879959297
Description:
Add a new interstitial search suggestion screen which displays autocomplete and device app results similar to that of the system default google app.
This interstitial screen is displayed when users launch our app
Steps to test this PR:
Test launch from Widget
m_w_l
firesTest launch from Assistant
m_a_l
firesTest launch from Google action
adb shell am start -a com.duckduckgo.mobile.android.NEW_SEARCH
to send the correct action to our appm_g_l
firesTest Dax icon opens main app
m_i_ld
firesTest autocomplete selection opens entry in browser
m_i_lbq
firesTest app selection entry opens app
Goo
m_i_sda
firesTest UI
Test Migration
Internal references:
Software Engineering Expectations
Technical Design Template