Skip to content

Delete unnecessary SafeWebViewFeature #7091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

Delete unnecessary SafeWebViewFeature #7091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ import com.duckduckgo.app.browser.webshare.WebShareChooser
import com.duckduckgo.app.browser.webshare.WebViewCompatWebShareChooser
import com.duckduckgo.app.browser.webview.WebContentDebugging
import com.duckduckgo.app.browser.webview.WebViewBlobDownloadFeature
import com.duckduckgo.app.browser.webview.safewebview.SafeWebViewFeature
import com.duckduckgo.app.cta.ui.BrokenSitePromptDialogCta
import com.duckduckgo.app.cta.ui.Cta
import com.duckduckgo.app.cta.ui.CtaViewModel
Expand Down Expand Up @@ -563,9 +562,6 @@ class BrowserTabFragment :
@Inject
lateinit var newTabPageProvider: NewTabPageProvider

@Inject
lateinit var safeWebViewFeature: SafeWebViewFeature

@Inject
lateinit var duckPlayer: DuckPlayer

Expand Down Expand Up @@ -3210,7 +3206,6 @@ class BrowserTabFragment :
).findViewById<DuckDuckGoWebView>(R.id.browserWebView)

webView?.let {
it.isSafeWebViewEnabled = safeWebViewFeature.self().isEnabled()
it.webViewClient = webViewClient
it.webChromeClient = webChromeClient
it.clearSslPreferences()
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/duckduckgo/app/browser/DuckDuckGoWebView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class DuckDuckGoWebView :
private val helper = CoordinatorLayoutHelper()

private var isDestroyed: Boolean = false
var isSafeWebViewEnabled: Boolean = false
private var isSafeWebViewEnabled: Boolean = true

@Inject
lateinit var dispatcherProvider: DispatcherProvider
Expand Down
32 changes: 0 additions & 32 deletions app/src/main/java/com/duckduckgo/app/browser/webview/safewebview/SafeWebViewFeature.kt
View file
Open in desktop

This file was deleted.

Loading