Add pictogram ripple effect to AI settings #7077
Merged
+56
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0nko
commented
Nov 7, 2025
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:scaleType="fitCenter" | ||
| android:scaleType="fitXY" |
Member
Author
There was a problem hiding this comment.
Had to change this because the ImageView container would be slightly taller than the image itself and the touch ripple would go outside the bounds.
joshliebe
reviewed
Nov 7, 2025
...d-design-system/design-system/src/main/res/drawable/background_large_rounded_transparent.xml
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 7, 2025
| @@ -0,0 +1,25 @@ | |||
| <?xml version="1.0" encoding="utf-8"?><!-- | |||
| ~ Copyright (c) 2024 DuckDuckGo | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ~ Copyright (c) 2024 DuckDuckGo | |
| ~ Copyright (c) 2025 DuckDuckGo |
joshliebe
approved these changes
Nov 7, 2025
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
Nice improvement! ✨ LGTM 🙂
…ground_large_rounded_transparent.xml Co-authored-by: Josh Leibstein <joshliebe@gmail.com>
0nko
deleted the
feature/ondrej/add-pictogram-ripple-effect-ai-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/715106103902962/task/1211861383768919?focus=true
Description
This PR adds a ripple effect to the AI settings pictograms.
Steps to test this PR
UI changes
Screen_recording_20251107_100953.webm