Duck.ai: Fullscreen mode FF #7055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
feature/david/11-04-duck.ai_fullscreen_mode_ff
branch
from
f4d0082 to
23f4be4
Compare
malmstein
force-pushed
the
feature/david/11-04-duck.ai_fullscreen_mode_ff
branch
from
23f4be4 to
fd6759f
Compare
joshliebe
reviewed
Nov 5, 2025
|
|
||
| suspend fun setShowInAddressBar(showDuckChat: Boolean) | ||
|
|
||
| suspend fun setFullScreenModeUserSetting(enabled: Boolean) |
joshliebe
reviewed
Nov 5, 2025
|
|
||
| suspend fun setShowInAddressBar(showDuckChat: Boolean) | ||
|
|
||
| suspend fun setFullScreenModeUserSetting(enabled: Boolean) |
joshliebe
reviewed
Nov 5, 2025
| withContext(dispatchers.io()) { | ||
| duckChatFeatureRepository.setFullScreenModeUserSetting(enabled) | ||
| cacheUserSettings() | ||
| } |
joshliebe
approved these changes
Nov 5, 2025
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
Tested, LGTM. Just missing some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211834986565997?focus=true
Description
This PR adds a FF for the new full screen mode. No functionality has been added to it.
Steps to test this PR
Internal flavour
Play flavour