Skip to content

Add base script for de-risking new WebViewCompat APIs #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

Add base script for de-risking new WebViewCompat APIs #7034

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a260c9e
Add base script for de-risking new WebViewCompat APIs
CrisBarreiro Oct 30, 2025
8923678
Don't re-define pingMessage
CrisBarreiro Oct 30, 2025
31f03cf
Only add timeout if delay > 0
CrisBarreiro Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions app/src/main/res/raw/webviewcompat_test_script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
const supportedMessages = ["ContextMenuOpened", "PageStarted"];

const delay = $DELAY$;
const postInitialPing = $POST_INITIAL_PING$;
const replyToNativeMessages = $REPLY_TO_NATIVE_MESSAGES$;

const webViewCompatPingMessage = 'Ping:' + window.location.href + ' ' + delay + 'ms'


if (postInitialPing) {
if (delay > 0) {
setTimeout(() => {
webViewCompatTestObj.postMessage(webViewCompatPingMessage)
}, delay)
} else {
webViewCompatTestObj.postMessage(webViewCompatPingMessage)
}
}


webViewCompatTestObj.onmessage = function(event) {
Copy link
Member

@CDRussell CDRussell Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it matter if native haven't defined a web message listener? e.g., will webViewCompatTestObj not being defined cause an issue?

Copy link
Contributor Author

@CrisBarreiro CrisBarreiro Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have some sort of message listener for all testing scenarios, so it shouldn't be a concern. Also, we don't have a proper way to know if a listener is defined on the native side. In any case, AFAIK, if no listener is defined, we'll see a log in Chrome console, but otherwise, the script would work as normal, with messages being, of course, ignored by native

console.log("webViewCompatTestObj received", event.data)
if (replyToNativeMessages && supportedMessages.includes(event.data)) {
webViewCompatTestObj.postMessage(event.data + " from webViewCompatTestObj")
}
}

window.onmessage = function(event) {
console.log("window received", event.data)
if (replyToNativeMessages && supportedMessages.includes(event.data)) {
webViewCompatTestObj.postMessage(event.data + " from window")
}
}
Loading