Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Sep 22, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1210561963620629?focus=true

Description

Add VPN menu item in New Tab page for UK users

Steps to test this PR

Pre-steps

Not Subscribed

  • Fresh install
  • Open a new tab page
  • Check you see the new VPN menu item with pill "TRY FOR FREE"

Subscribed & Active

  • Tap on VPN menu item
  • Subscription paywall is opened with origin "funnel_appmenu_android" (you can check this in the logcat filtering by "origin"
  • Purchase a subscription
  • Once the purchase is finished, go back to new tab page
  • Open overflow menu
  • Check VPN menu item is there with off indicator

Subscribed & Not Active

  • Tap on VPN menu item
  • Check it navigates to VPN management screen
  • Enable VPN
  • Go back to new tab page
  • Open overflow menu
  • Check VPN menu item is there with on indicator

Browser Menu

  • Make a search
  • Open overflow menu
  • Check VPN menu item is not there
  • Go to a website
  • Check VPN menu item is not there either

Not en-GB

  • Switch your device language to something other than English (United Kingdom)
  • Go back to the browser
  • Open a new tab
  • Open overflow menu
  • Check VPN is not there, as user it is not eligible

FF disabled

UI changes

Not Subscribed Subscribed & Active Subscribed & Not Active
vpn-menu-not-subscribed vpn-menu-subscribed-active vpn-menu-subscribed-not-active

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag force-pushed the feature/noelia/vpn_menu_item branch from e778a5a to eaaee2a Compare September 22, 2025 17:08
@nalcalag nalcalag marked this pull request as ready for review September 22, 2025 17:38
@nalcalag nalcalag force-pushed the feature/noelia/vpn_menu_item branch from eaaee2a to bb4e4e8 Compare September 23, 2025 11:38
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@nalcalag nalcalag merged commit 91899c6 into develop Sep 23, 2025
9 checks passed
@nalcalag nalcalag deleted the feature/noelia/vpn_menu_item branch September 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants